[fix] #2133: Rewrite topology to be closer the whitepaper.

[SamHSmith]

Description of the Change

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

[codecov]

Codecov Report

Merging #3250 (21244c4) into iroha2-dev (a4d5c9f) will increase coverage by 0.34%.
The diff coverage is 54.98%.

❗ Current head 21244c4 differs from pull request most recent head b563ae1. Consider uploading reports for the commit b563ae1 to get more accurate results

@@              Coverage Diff               @@
##           iroha2-dev    #3250      +/-   ##
==============================================
+ Coverage       62.33%   62.67%   +0.34%     
==============================================
  Files             169      159      -10     
  Lines           31218    31826     +608     
==============================================
+ Hits            19459    19948     +489     
- Misses          11759    11878     +119     

Impacted Files	Coverage Δ
cli/src/main.rs	0.85% <0.00%> (-0.25%)	⬇️
cli/src/samples.rs	57.97% <ø> (-3.88%)	⬇️
cli/src/torii/mod.rs	27.65% <ø> (ø)
client_cli/src/main.rs	0.24% <0.00%> (-0.01%)	⬇️
config/base/src/lib.rs	91.57% <ø> (+55.21%)	⬆️
config/src/lib.rs	33.33% <ø> (ø)
config/src/path.rs	0.00% <0.00%> (ø)
config/src/wasm.rs	100.00% <ø> (ø)
core/src/lib.rs	100.00% <ø> (ø)
core/src/smartcontracts/isi/asset.rs	50.88% <0.00%> (-2.65%)	⬇️
... and 185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Erigara]

@SamHSmith can you please explain why we need to carry topology in every block since every peer anyway uses it's own topology to verify that received topology is correct?

[SamHSmith]

@SamHSmith can you please explain why we need to carry topology in every block since every peer anyway uses it's own topology to verify that received topology is correct?

The old topology was based on a block has and a view change index. This is bad for security since the leader can influence the block hash and therefore influence the future topology.

Now that we have a constantly evolving topology whos operations are destructive, rolling back becomes harder. Instead of keeping old topologies around locally we store it in the block header. This way when there is a softfork or odd consensus a peer can see that enough peers signed this block and adopt the topology. Topology is checked while verifying but not when receiving block through syncing.