chore: add eslint, styling checks, and enforce via husky #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
eslint --fixto autofix linting issueslint-stagedandhuskypre-commithookpackage.jsonkey order vialint-stagedandhuskypre-commithookno functionality should be changed as part of this PR
I attempted to keep the linting as "non-custom" as possible by minimizing eslint plugins used. Later on, we might revisit this ie. lint order of dependencies in files, or even linting
package.jsons to to be in a consistent order.Some files, I wasn't sure on whether we wanted to remove the unused variables, as I think they are being used to demonstrate the contract of the service/adapter. Instead of that, we should use jsdoc and module types, eventually. I will create an issue to track revisiting those instances where I disabled linting rules and to resolve them where applicable. Would be good first issue for a contributor, I think.