Skip to content

Conversation

@smalluban
Copy link
Contributor

@smalluban smalluban commented Oct 9, 2025

The PR loses protection from passing the id property in store.set(model, values) method.

Sometimes, the data provided by external source contains the id, so before the data object had to be obscured from id to make it possible to update the model.

@coveralls
Copy link

coveralls commented Oct 9, 2025

Coverage Status

coverage: 99.915% (+0.001%) from 99.914%
when pulling 856ab58 on fix-store
into 8b29696 on main.

@smalluban smalluban changed the title fix(store): support fo the same id in values for settings model instance fix(store): id in values & minor pending state bugfix Oct 9, 2025
@smalluban smalluban merged commit 94efadf into main Oct 9, 2025
2 checks passed
@smalluban smalluban deleted the fix-store branch October 9, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants