Skip to content

Conversation

@xyz-26
Copy link
Contributor

@xyz-26 xyz-26 commented Mar 17, 2025

…dd test cases for the corresponding options type

@coveralls
Copy link

coveralls commented Mar 17, 2025

Coverage Status

coverage: 94.737%. remained the same
when pulling 3072b24 on xyz-26:fix/options-type-incompatibility
into e150dc1 on hustcc:master.

@xyz-26
Copy link
Contributor Author

xyz-26 commented Mar 17, 2025

主要加了个联合类型,加了个测试用例。如果echarts的类型一直是两个引用的话ts就不能彻底解决这个问题,会不会回退any会更合适呢

@hustcc
Copy link
Owner

hustcc commented Mar 17, 2025

先 any 吧,然后去 echarts 提交 issue 解决试试。

其实即使解决,对于使用旧版本的 echarts 还是会抱错。

@xyz-26
Copy link
Contributor Author

xyz-26 commented Mar 19, 2025

安装echarts@4、@types/echarts@4的时候,由于找不到这个类型引用的具体类型,ts会认为他是any,也不会有这个问题。
那我先改成any

@hustcc
Copy link
Owner

hustcc commented Mar 19, 2025

看看 diff,尽量减少 diff 。

@xyz-26 xyz-26 force-pushed the fix/options-type-incompatibility branch from 5c07375 to 3072b24 Compare March 19, 2025 14:04
@hustcc
Copy link
Owner

hustcc commented Mar 19, 2025

还在 draft 中,合并不了~

@xyz-26 xyz-26 marked this pull request as ready for review March 19, 2025 14:32
@hustcc hustcc merged commit da0dd24 into hustcc:master Mar 20, 2025
3 checks passed
@hustcc
Copy link
Owner

hustcc commented Mar 20, 2025

@imsuvesh
Copy link

@hustcc, is there any chance of this getting released early? As 3.0.3 introduced a breaking change in a minor patch release,

projects who use strict type checking using ComposeOption getting TS breaking error when upgrading to minor patch 3.0.2 to 3.0.3 release

Or mention breaking change in release notes

@hustcc
Copy link
Owner

hustcc commented Mar 21, 2025

I will deprecate v3.0.3 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants