This repository was archived by the owner on Dec 6, 2024. It is now read-only.
Add authentication when using JWT with oauth2 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafa-munoz
suggested changes
Jul 10, 2018
Dockerfile.dev
Outdated
| WORKDIR /code | ||
| RUN pip install tox | ||
| ADD . /code | ||
| ADD . /code |
There was a problem hiding this comment.
This change is not necessary. Every file should end in a new line
docker-compose-dev.yml
Outdated
| image: dot_jwt | ||
| volumes: | ||
| - .:/code | ||
| - .:/code |
There was a problem hiding this comment.
This change is not necessary. Every file should end in a new line
| if payload_enricher: | ||
| fn = import_string(payload_enricher) | ||
| extra_data = fn(request) | ||
| extra_data['username'] = request.POST.get('username') |
There was a problem hiding this comment.
Every request won't have a username. For example on refresh_token actions. It should not be inside this if payload_enricher and something like:
if request.POST.get('username'):
extra_data['username'] = request.POST.get('username')
rafa-munoz
approved these changes
Jul 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have already added the authentication, please double check and let me know if you found any issues