🔧 Use partial for worker_init_fn in GRPO and OnlineDPO trainers to include num_workers and rank, fixes bug https://github.com/huggingface/trl/issues/3544 #3547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clude num_workers and rank, fixes bug huggingface#3544
|
Thanks! I missed your PR and opened a duplicate: #3568 🤦♂️ |
|
Lol, no problem. |
|
yes, closing as duplicate of #3568 |
|
@avishaiElmakies So sorry I could not review your PR earlier! My focus is on some refactoring stuff these days so I am abit behind for reviews! Sorry abt it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3544
also checked if other trainers have the same issue and found that only online dpo has it. so changed it there as well
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.