generated from fastai/nbdev_template
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
🙋 Add Optional Eager Execution Mode for vLLM Serving #3335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the user to set Eager Execution instead of building cuda graph to save memory.
Update vllm_serve.py
qgallouedec
reviewed
Apr 21, 2025
qgallouedec
reviewed
Apr 21, 2025
Co-authored-by: Quentin Gallouédec <[email protected]>
Co-authored-by: Quentin Gallouédec <[email protected]>
qgallouedec
reviewed
Apr 21, 2025
Co-authored-by: Quentin Gallouédec <[email protected]>
qgallouedec
approved these changes
Apr 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces a new optional flag,
enforce_eager
, to the VLLM serving script. This enhancement gives users control over the execution mode of the model, allowing them to choose between eager execution or the default hybrid CUDA graph approach based on their specific needs. See https://docs.vllm.ai/en/stable/api/offline_inference/llm.html#vllm.LLMChanges Made
enforce_eager_flag
to theScriptArguments
class intrl/scripts/vllm_serve.py
main
function to pass this flag asenforce_eager
to the model configurationFalse
to maintain backward compatibility with existing behaviorBenefits
Technical Details
The changes primarily affect:
trl/scripts/vllm_serve.py
- Added new flag to the argument parser and passed it to the model configurationTesting
Verified the flag works correctly in both states:
enforce_eager_flag=True
: Model uses pure eager executionenforce_eager_flag=False
(default): Model uses hybrid CUDA graph executionRelated Issues
Fixes #XXXX
Checklist Before Submitting
Who Can Review?
Anyone in the community is welcome to review once tests have passed. Team members with expertise in model serving or CUDA optimization would be particularly valuable reviewers.