🐯 is_liger_kernel_available
with min version
#3266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @lewtun
From me:
I suggest the following solution. Now when you run
is_liger_kernel_available
without the min version, it returnsFalse
.It's a shame that you have to specify the min version in two places (
setup.py
andimport_utils.py
), but I can't think of any other easy and readable way to do it.This implementation actually matches that of transformers, which, as everyone knows, is the source of all truth 🙇: https://github.com/huggingface/transformers/blob/main/src/transformers/utils/import_utils.py
We could do this with all our optional dependencies. But it's a bit time-consuming, so I'll leave it to follow-up PRs.