♾️ [CI] Remove test_raise_error_not_causallm
#3265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR huggingface/transformers#37173 removes
GenerationMixin
inheritance by default inPreTrainedModel
. Consequently,AutoModel
now returns object without methodprepare_inputs_for_generation
.This line:
trl/trl/models/modeling_base.py
Line 91 in 1d7b8c4
causes a premature error in this test
test_modeling_value_head.py::Seq2SeqValueHeadModelTester::test_raise_error_not_causallm
trl/tests/test_modeling_value_head.py
Lines 384 to 390 in 1d7b8c4
which is bound to fail anyway, because that's what we're testing.
I propose to remove this test, which in fact tests a part of the codebase that is very little used, with a model that is also very little used.