📉 Add learning_rate argument to _maybe_log_save_evaluate
#3206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qgallouedec
changed the title
learning_rate argument to _maybe_log_save_evaluatelearning_rate argument to _maybe_log_save_evaluate
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
We can safely ignore the failing CI, it's related to the hub timeout, fixed in of #3174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR is on
release v0.16branch!This PR addresses a breaking change introduced in the
transformersdev branch: huggingface/transformers#36973. This was fixed in thetrlmain branch with #3176, but this fix is not part of TRL 0.16, which could cause issues once transformers new release goes live. To prevent this, we will release v0.16.1, which includes a fix.By releasing this patch ahead of the upcoming
transformersrelease, users will avoid potential bugs caused by the breaking change intransformersdev branch. This ensures thattrlremains compatible with the newtransformersversion as soon as it's released.This breaking case was reported thanks to this CI: https://github.com/huggingface/trl/actions/workflows/tests_latest.yml