generated from fastai/nbdev_template
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
🚀 Scaling GRPO to 70B+ Models and Multi-Node Training with vLLM Server & NCCL Communication #3094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 56 commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
765891c
🚀allow GRPO to connect to VLLM in remote/local node with NCCL communi…
binary-husky 42f2131
Update trl/extras/remote_vllm_helper.py
binary-husky 715d486
use argparse for options
kashif 60a6753
add imports for remote vllm helper
kashif f784a8c
formatting
kashif 5628b60
fix arguments
kashif 8bfc313
use cli options
kashif d63c94a
vllm serve
qgallouedec c2e970f
clean server
qgallouedec e50d288
better naming
qgallouedec c723685
client
qgallouedec 5d19cf1
style
qgallouedec b5ff472
new params in generate
qgallouedec e5fe142
this method is the new default
qgallouedec 73853fc
update config
qgallouedec 1fbdf69
Merge branch 'main' into main
qgallouedec 94625f9
do not use asserts
kashif 9335e68
update config
qgallouedec 06aca0a
separate host and post
qgallouedec a7af2e2
Merge branch 'main' of https://github.com/binary-husky/trl into pr/bi…
qgallouedec a92b296
proper deprectation
qgallouedec 714a833
deprecated arg in the vllm server
qgallouedec 71024d6
simplify moving
qgallouedec bbf99f1
document host and port
qgallouedec a7e9dea
style
qgallouedec 2b7fb1a
update trainer
qgallouedec 5fee194
new generate args
qgallouedec 508bd90
update doc
qgallouedec 75bd4e3
Fix for zero3
qgallouedec 5a8138c
Better naming
qgallouedec 5f19c70
Remove remote_vllm_helper
qgallouedec 4ae6cb4
remove grpo_with_remote_vllm
qgallouedec 9ca4dde
remove cloudpickle from deps
qgallouedec 5d1398e
Some consistency
qgallouedec e85c7bb
Merge branch 'main' into main
qgallouedec 44ae792
Update docs/source/grpo_trainer.md
kashif 060c4a6
Update setup.py
kashif d581a5f
add revision argument to vllm server
kashif 128b503
Update docs/source/grpo_trainer.md
kashif 724e013
Update docs/source/grpo_trainer.md
kashif daf2cde
Reset the prefix cache after updating weights
kashif 75bfbc4
Merge remote-tracking branch 'refs/remotes/binary-husky/main'
kashif bb1fb55
Update vllm_client.py
qgallouedec 415f3ca
Update vllm_client.py
qgallouedec 1053197
Update vllm_serve.py
qgallouedec e6a4901
Add health check endpoint to vLLM server
qgallouedec e763064
connection timeout
qgallouedec 4554af9
style
qgallouedec 92a154f
fix doc langauge hint
qgallouedec 666a6e4
Merge branch 'main' into main
kashif 6537a7e
move reset_prefix_cache to its own endpoint
kashif 821d37e
Merge branch 'main' of https://github.com/binary-husky/trl into pr/bi…
qgallouedec c38e79f
async
qgallouedec 92cf3e0
merge peft adaptor to send to vllm
kashif 0ffec9f
Looks simple. Wasn't.
qgallouedec d9d28db
Peft compatibility
qgallouedec d452a2f
Update docs/source/speeding_up_training.md
kashif dd873cf
Update docs/source/speeding_up_training.md
kashif 7e11184
Update trl/extras/vllm_client.py
kashif 6c4bf00
GatheredParameters can be disabled
kashif c431b0f
gather and ungather peft weights within the same deepseed context
kashif 67c4e68
use is_vllm_available
kashif 15fcaaf
minor consistency fixes
qgallouedec 09ec2a1
fix error when deepspeed is not installed
kashif bc2f902
fix deepspeed import when not peft
kashif db8d5fd
Merge branch 'main' of https://github.com/binary-husky/trl into pr/bi…
qgallouedec 89812ee
simpler
kashif bb66c91
multinode doc
qgallouedec b23c23f
minor code and comments changes
qgallouedec 5111c8f
Merge branch 'main' of https://github.com/binary-husky/trl into pr/bi…
qgallouedec 657cb21
style
qgallouedec 8670c35
optional deps
qgallouedec 7955a39
vllm_server_timeout as arg
qgallouedec 5a37647
small refinement in doc
qgallouedec 10d26ef
update deps
qgallouedec d759c9c
Fix VLLMClient argument in grpo_trainer; Add zero3+peft vllm transfer…
binary-husky 4fc8790
Revert "Fix VLLMClient argument in grpo_trainer; Add zero3+peft vllm …
qgallouedec fb28f62
log num_tokens
qgallouedec 3a211e6
disable vllm test (in the future we'll add a mock for vllm server for…
qgallouedec 7a81655
style
qgallouedec 716a822
fix ds3_gather_for_generation
qgallouedec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.