🌡️ Fix temperature inconsistency in GRPO trainer #3029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the temperature scaling omission when computing the model's and reference model's log probabilities, potentially causing highly biased policy gradients.
This should be consistent with other TRL implementations as PPO and RLOO. Omitting this term has been evidenced to potentially cause detrimental instabilities when fine-tuning LLMs with RL (e.g., see here). Consistently with these results, using my own custom implementation after this fix also seems to work better. I tried doing additional research, but I could not find references that mention purposefully biasing the optimization leads to benefits... am I missing something?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.