Skip to content

↩️ Fix typo in TextEnvironment init param, should be max_tool_response #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shenxiangzhuang
Copy link
Contributor

@shenxiangzhuang shenxiangzhuang commented Feb 21, 2025

Fix typo, should be max_tool_response.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@qgallouedec qgallouedec changed the title chore(typo): fix typo in TextEnvironment init param, should be max_to… ↩️ Fix typo in TextEnvironment init param, should be max_tool_response Feb 24, 2025
@qgallouedec qgallouedec merged commit 9b76d5f into huggingface:main Feb 24, 2025
6 of 13 checks passed
kashif pushed a commit that referenced this pull request Feb 27, 2025
jhinpan pushed a commit to jhinpan/trl-jin that referenced this pull request Mar 12, 2025
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants