-
Notifications
You must be signed in to change notification settings - Fork 2.1k
⏪ Parameterize enable_prefix_caching
#2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Can you just please update the doc and we're good to merge
6492607
to
c7d8a26
Compare
c7d8a26
to
416908b
Compare
@qgallouedec Made the suggested change. :) |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
enable_prefix_caching
* parameterize enable_prefix_caching * apply review suggestion --------- Co-authored-by: Quentin Gallouédec <[email protected]>
* parameterize enable_prefix_caching * apply review suggestion --------- Co-authored-by: Quentin Gallouédec <[email protected]>
* parameterize enable_prefix_caching * apply review suggestion --------- Co-authored-by: Quentin Gallouédec <[email protected]>
What does this PR do?
Fixes #2798
Tested using the configuration (for functional verification only) of open-r1 with minor modifications:
with

vllm_enable_prefix_cache: true (default)
:with
vllm_enable_prefix_cache: false
:Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @qgallouedec