🪪 Adds profiling decorators for GRPOTrainer #2889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbeeching
commented
Feb 18, 2025
trl/trainer/grpo_trainer.py
Outdated
|
|
||
| SLIDER_TABLE = True |
There was a problem hiding this comment.
sorry accidently included this, I will revert
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Cool!! |
qgallouedec
approved these changes
Feb 18, 2025
qgallouedec
changed the title
jhinpan
pushed a commit
to jhinpan/trl-jin
that referenced
this pull request
Mar 12, 2025
* adds profiling decorator * naming + precommit * style * revert inclusion of slider table * revert 2 * revert3 * revert4 * revert 5 fml --------- Co-authored-by: Quentin Gallouédec <[email protected]>
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* adds profiling decorator * naming + precommit * style * revert inclusion of slider table * revert 2 * revert3 * revert4 * revert 5 fml --------- Co-authored-by: Quentin Gallouédec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a profiling decorator and wraps some key methods in the GRPO trainer. If you are reporting to wandb you now have a profiling section with some timings:
