Skip to content

Conversation

tomaarsen
Copy link
Member

@tomaarsen tomaarsen commented Sep 16, 2022

What does this PR do?

Prevent a hyperlink from displaying as the full markdown representation near the bottom of the PreTrainedModel.save_pretrained documentation. Currently, the additional backticks cause the body to be deemed a code block, preventing it from becoming a link like it should be.

The current situation

image

The new situation

See here for the documentation after this PR.
image

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

@sgugger

  • Tom Aarsen

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 16, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit 532ca05 into huggingface:main Sep 16, 2022
@tomaarsen tomaarsen deleted the docs/fix_links branch September 16, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants