Skip to content

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Sep 15, 2022

What does this PR do?

Run torchdynamo tests

Fix #18127

@ydshieh ydshieh force-pushed the to_run_torchdynamo_tests branch from f07b06b to 04ed4ce Compare September 15, 2022 17:03
@ydshieh ydshieh requested a review from stas00 September 15, 2022 17:21
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 15, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Sep 15, 2022

Taking the fix in #18685 by @anijain2305 , thank you!

Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the fix and the test instrumentation, @ydshieh!

@ydshieh ydshieh requested a review from sgugger September 15, 2022 18:08
@ydshieh
Copy link
Collaborator Author

ydshieh commented Sep 15, 2022

Need core maintainer's approval to merge :-)

@stas00 stas00 merged commit 16242e1 into main Sep 15, 2022
@stas00 stas00 deleted the to_run_torchdynamo_tests branch September 15, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

todo: enable CI to run torchdynamo/tensorrt tests

3 participants