Skip to content

Conversation

daspartho
Copy link
Contributor

Based on the issue #16059
@Rocketknight1 could you please take a look at it?
Thanks :)

@Rocketknight1
Copy link
Member

Rocketknight1 commented Sep 15, 2022

Hi @daspartho, thanks for this! There's one problem, though - one of the functions you added type hints to was marked as copied from another function. This caused the check_repository_consistency test to fail. If you check the details on that test, the problem is that those functions were copied from Wav2Vec2Encoder and Wav2Vec2EncoderStableLayerNorm. If you add type hints to those Wav2Vec2 functions so that they match, and then finally run make fix-copies that should resolve this!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 15, 2022

The documentation is not available anymore as the PR was closed or merged.

@daspartho
Copy link
Contributor Author

Hello, @Rocketknight1
I did as you suggested but more copy inconsistencies arised, could you assist me with this?

@Rocketknight1
Copy link
Member

Hi @daspartho, I think running make fix-copies in the root directory of the repo should fix this! If it's not working for you, let me know and I'll run it for you - just make sure the PR is set to allow commits from maintainers.

@daspartho
Copy link
Contributor Author

daspartho commented Sep 16, 2022

Hi, @Rocketknight1. I tried running it but I'm not sure why it's not working; could you please run it for me? Thanks :)

@Rocketknight1
Copy link
Member

@daspartho Done! Double-check the changes and make sure you're happy with them, and I'll merge once you are.

@daspartho
Copy link
Contributor Author

@Rocketknight1 I've checked the changes and I'm happy with them. Thank you very much!

@Rocketknight1 Rocketknight1 merged commit 5e636ee into huggingface:main Sep 16, 2022
@daspartho daspartho deleted the type_hints branch September 16, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants