Skip to content

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 18, 2022

What does this PR do?

The commit 36a65a0907d90ed591479b2ebaa8b61cfa0b4ef0 in detectron2 break things, see here.

Ping the parent commit until that issue is fixed.

Issue found by @amyeroberts

- run: pip install .[torch,testing,vision]
- run: pip install torchvision
- run: python -m pip install 'git+https://github.com/facebookresearch/detectron2.git'
- run: python -m pip install 'git+https://github.com/facebookresearch/detectron2.git@5aeb252b194b93dc2879b4ac34bc51a31b5aee13'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably add a comment here.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @ydshieh !

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 18, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 18, 2022

Merge now to avoid CI failure on PRs.

@ydshieh ydshieh changed the title Ping detectron2 for CircleCI tests Ping detectron2 for CircleCI tests Aug 18, 2022
@ydshieh ydshieh merged commit 2c947d2 into huggingface:main Aug 18, 2022
@ydshieh ydshieh changed the title Ping detectron2 for CircleCI tests Pin detectron2 for CircleCI tests Aug 18, 2022
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Aug 18, 2022
@ydshieh ydshieh deleted the pin_dectectron2 branch September 7, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants