add mobilebert onnx configs
#17029
add mobilebert onnx configs
#17029
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
Hi @manandey thanks for the PR, it looks really clean. Did you try to convert one MobileBERT model with this config? It could be nice to upload a converted MobileBERT model of your choice to the |
There was a problem hiding this comment.
Thanks for this clean PR @manandey 🤗 ! I've left some comment for small things we need to change, but this is a great start!
Could you also please confirm that the slow tests pass by running:
RUN_SLOW=1 pytest tests/onnx/test_onnx_v2.py -s -k "mobilebert"
|
Hi @lewtun, I tried to address the fixes you had suggested, and the tests are passing after running |
There was a problem hiding this comment.
Thanks for iterating and checking that the tests pass @manandey 🤗 ! The last thing I suggest is rebasing your branch on main to incorporate a refactoring we just merged that orders all the model names alphabetically in features.py.
* update docs of length_penalty * Revert "update docs of length_penalty" This reverts commit 466bf48. * add mobilebert onnx config * address suggestions * Update auto.mdx * Update __init__.py * Update features.py
What does this PR do?
This PR adds MobileBert OnnxConfig to make this model available for conversion. #16308
Who can review?
@lewtun @LysandreJik
Anyone in the community is free to review the PR once the tests have passed.