Fix distributed_concat with scalar tensor
#16963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sgugger |
sgugger
reviewed
Apr 27, 2022
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 27, 2022
chamidullinr
pushed a commit
to chamidullinr/transformers
that referenced
this pull request
Apr 28, 2022
* Fix `distributed_concat` with scalar tensor * Update trainer_pt_utils.py
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Fix `distributed_concat` with scalar tensor * Update trainer_pt_utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If a scalar tensor is passed to
distributed_concat, the output tensors are correctly converted to one element vectors. However, this is not done for the tensor itself, which causes an exception to be thrown indist.all_gatherdue to a tensor length mismatch. This PR fixes that.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.