Skip to content

Fix multiple deletions of the same files in save_pretrained #16947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Fix multiple deletions of the same files in save_pretrained #16947

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c843460
Fix multiple deletions of the same files in save_pretrained
sgugger Apr 26, 2022
7e9142d
Add is_main_process argument
sgugger Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,14 @@ def save_pretrained(
# Clean the folder from a previous save
for filename in os.listdir(save_directory):
full_filename = os.path.join(save_directory, filename)
if filename.startswith(WEIGHTS_NAME[:-4]) and os.path.isfile(full_filename):
# If we have a shard file that is not going to be replaced, we delete it, but only from the main process
# in distributed settings (save_config=True) to avoid race conditions.
if (
filename.startswith(WEIGHTS_NAME[:-4])
and os.path.isfile(full_filename)
and filename not in shards.keys()
and save_config
):
os.remove(full_filename)

# Save the model
Expand Down