Rename the method test_torchscript

[ydshieh]

What does this PR do?

class ModelTesterMixin has attribute test_torchscript as well as method named def test_torchscript.

In a few model specific test files, we have test_torchscript = True defined, for example,

T5ModelTest:

transformers/tests/t5/test_modeling_t5.py

Line 515 in 7c5d799

test_torchscript = True

DistilBertModelTest:

transformers/tests/distilbert/test_modeling_distilbert.py

Line 214 in 7c5d799

test_torchscript = True

This actually makes the test_torchscript being a boolean value instead of a method, therefore test_torchscript is not run for these places. See the last section for a dummy example.

Fix

Although this could be fixed just by removing test_torchscript = True, it would be a better idea to rename the method def test_torchscript to something else like def test_torchscript_simple.

Dummy example (to reproduce the issue)

class DummyCommonTest:

    test_me = True

    def test_me(self):
        a = 3
        print(a)

class DummyModelTest1(DummyCommonTest):

    pass

class DummyModelTest2(DummyCommonTest):

    test_me = True

dummy_test = DummyCommonTest()
print(dummy_test.test_me)
dummy_test.test_me()

dummy_model_test_1 = DummyModelTest1()
# A method
print(dummy_model_test_1.test_me)
# can be called
dummy_model_test_1.test_me()

dummy_model_test_2 = DummyModelTest2()
# A boolean
print(dummy_model_test_2.test_me)
# can't be called: (TypeError: 'bool' object is not callable)
dummy_model_test_2.test_me()

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[LysandreJik]

Great catch, LGTM!