-
Notifications
You must be signed in to change notification settings - Fork 30.2k
Enable more test_torchscript #16679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ydshieh
merged 10 commits into
huggingface:main
from
ydshieh:update_create_and_check_torchscript
Apr 11, 2022
Merged
Enable more test_torchscript #16679
ydshieh
merged 10 commits into
huggingface:main
from
ydshieh:update_create_and_check_torchscript
Apr 11, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner, LGTM!
sgugger
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* update _create_and_check_torchscript * Enable test_torchscript * clear_class_registry Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable more
test_torchscript
(in 30 files) by updating_create_and_check_torchscript
.(There are still 21 files with 23 places being
False
at this moment - they still give errors.)The main place to review is in
test_modeling_common.py
.The changes in model specific test files are removing lines regarding
test_torchscript = True/False
.