Skip to content

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 9, 2022

What does this PR do?

Enable more test_torchscript (in 30 files) by updating _create_and_check_torchscript.

(There are still 21 files with 23 places being False at this moment - they still give errors.)

The main place to review is in test_modeling_common.py.
The changes in model specific test files are removing lines regarding test_torchscript = True/False.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 9, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh marked this pull request as ready for review April 11, 2022 07:07
@ydshieh ydshieh changed the title [WIP] update _create_and_check_torchscript Enable more test_torchscript Apr 11, 2022
@ydshieh ydshieh requested review from sgugger and LysandreJik April 11, 2022 07:10
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, LGTM!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@ydshieh ydshieh merged commit c04619e into huggingface:main Apr 11, 2022
@ydshieh ydshieh deleted the update_create_and_check_torchscript branch April 11, 2022 16:23
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* update _create_and_check_torchscript

* Enable test_torchscript

* clear_class_registry

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants