apply torch int div to layoutlmv2 #15457
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
REALM tests seem to be failing - doesn't seem like they should be running ? |
There was a problem hiding this comment.
This looks good to me! @NielsRogge can you give it a last look and merge if it looks good to you too?
Thanks for your contributions @ManuelFay!
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@ManuelFay can you rebase with master such that we can merge your PR? |
ManuelFay
force-pushed
the
remove-deprecation-warning-int-div-layoutlmv2
branch
from
108b8ac to
280880a
Compare
|
Done, and I changed the path to the custom divide function (compatible with older torch versions). @NielsRogge |
|
The documentation is not available anymore as the PR was closed or merged. |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
Hi @ManuelFay, apologies, for some reason this is still not merged. Can you rebase your PR with the main branch such that we can merge it? Apologies again for asking you this a second time. Thanks! |
ManuelFay
force-pushed
the
remove-deprecation-warning-int-div-layoutlmv2
branch
from
e278470 to
3e7e744
Compare
|
No problem @NielsRogge ! Here you go, rebased ;) |
* apply torch int div * black linting fixup * update path to torch_int_div * clarify imports
What does this PR do?
Linked to #14853 (now closed - bad rebase)
@LysandreJik