Skip to content

Improve post-processing performance #10170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

soof-golan
Copy link
Contributor

What does this PR do?

Closes #10158

  • Use multiplication instead of division
  • Add fast path when denormalizing all or none of the images

Context

As suggested by @yiyixuxu, this is a smaller PR than #10159 and only adds the fast path in the all-or-nothing scenario. leaving the selective denormalization as-is in the heterogeneous case.

* Use multiplication instead of division
* Add fast path when denormalizing all or none of the images
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit 22d3a82 into huggingface:main Dec 10, 2024
14 of 15 checks passed
@soof-golan soof-golan deleted the perf-denormlization-fast-path branch December 10, 2024 18:19
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* Use multiplication instead of division
* Add fast path when denormalizing all or none of the images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post processing performance can be improved
3 participants