Skip to content

Avoid compiling a progress bar. #10098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Avoid compiling a progress bar. #10098

merged 3 commits into from
Dec 3, 2024

Conversation

lsb
Copy link
Contributor

@lsb lsb commented Dec 3, 2024

What does this PR do?

This is useful when exporting a pipeline, and allows a compiler to avoid trying to compile away tqdm when it is explicitly excluded.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

This is useful when exporting a pipeline, and allows a compiler to avoid trying to compile away tqdm.
@lsb lsb changed the title Avoid creating a progress bar when it is disabled. Avoid compiling a progress bar. Dec 3, 2024
@lsb lsb requested a review from bghira December 3, 2024 16:43
@lsb lsb marked this pull request as ready for review December 3, 2024 17:01
Copy link
Contributor

@bghira bghira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tres bon, magnifique

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit 619b965 into huggingface:main Dec 3, 2024
15 checks passed
lawrence-cj pushed a commit to lawrence-cj/diffusers that referenced this pull request Dec 4, 2024
* Avoid creating a progress bar when it is disabled.

This is useful when exporting a pipeline, and allows a compiler to avoid trying to compile away tqdm.

* Prevent the PyTorch compiler from compiling progress bars.

* Update pipeline_utils.py
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* Avoid creating a progress bar when it is disabled.

This is useful when exporting a pipeline, and allows a compiler to avoid trying to compile away tqdm.

* Prevent the PyTorch compiler from compiling progress bars.

* Update pipeline_utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants