Skip to content

No need for dataset_info #7234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 21, 2024
Merged

No need for dataset_info #7234

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d07730a
no need for dataset_info
lhoestq Oct 17, 2024
a3251f7
actually do a single call in dataset_module_factory
lhoestq Oct 17, 2024
7c5eb4b
update tests
lhoestq Oct 17, 2024
c97703c
fix tests
lhoestq Oct 17, 2024
fd5836a
again
lhoestq Oct 17, 2024
1ef1e39
again
lhoestq Oct 18, 2024
24d0984
better check for gated error response code
lhoestq Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/datasets/download/download_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,11 @@ def _download_batched(
download_func = partial(self._download_single, download_config=download_config)

fs: fsspec.AbstractFileSystem
fs, path = url_to_fs(url_or_filenames[0], **download_config.storage_options)
path = str(url_or_filenames[0])
if is_relative_path(path):
# append the relative path to the base_path
path = url_or_path_join(self._base_path, path)
fs, path = url_to_fs(path, **download_config.storage_options)
size = 0
try:
size = fs.info(path).get("size", 0)
Expand Down
Loading
Loading