Skip to content

Set scripts version to master #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

Set scripts version to master #603

merged 1 commit into from
Sep 10, 2020

Conversation

@lhoestq
Copy link
Member

@lhoestq lhoestq commented Sep 10, 2020

By default the scripts version is master, so that if the library is installed with

pip install git+http://github.com/huggingface/nlp.git

or

git clone http://github.com/huggingface/nlp.git
pip install -e ./nlp

will use the latest scripts, and not the ones from the previous version.

thomwolf
thomwolf approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@lhoestq lhoestq merged commit 6318935 into master Sep 10, 2020
@lhoestq lhoestq deleted the use-master-scripts-version branch September 10, 2020 11:02
JetRunner pushed a commit that referenced this pull request Sep 17, 2020
@lhoestq @JetRunner
set scripts version to master (#603)
cc6bac9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomwolf thomwolf thomwolf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lhoestq @thomwolf