Skip to content

Conversation

@stefan-it
Copy link
Contributor

@stefan-it stefan-it commented Sep 9, 2020

Hi,

unfortunately, the download links for the GermEval 2014 dataset have changed: they're now located on a Google Drive.

I changed the URLs and bump version from 1.0.0 to 2.0.0.

@stefan-it
Copy link
Contributor Author

/cc: @vblagoje

@lhoestq lhoestq mentioned this pull request Sep 9, 2020
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the url :)

I noticed that you had to 'hack' the dummy data a bit. I managed to remove this hack and made another PR without the hack in #594

@lhoestq
Copy link
Member

lhoestq commented Sep 9, 2020

Closing this one as #594 is merged (same changes except the dummy data hack)

@lhoestq lhoestq closed this Sep 9, 2020
@vblagoje
Copy link
Contributor

vblagoje commented Sep 9, 2020

Awesome @stefan-it ! @lhoestq how soon can I use the fixed GermEval dataset in HF token classification examples?

@lhoestq
Copy link
Member

lhoestq commented Sep 9, 2020

I've manually updated the script on S3, so you can actually use it right now with

from nlp import load_dataset

germeval = load_dataset("germeval_14")

not sure if it's used in token classification examples already

@vblagoje
Copy link
Contributor

vblagoje commented Sep 9, 2020

Awesome. Not used yet but I am going to use it now. I've been working on an update for token classification examples and this was a missing piece. Thanks @stefan-it @lhoestq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants