Skip to content

Fix select for pyarrow < 1.0.0 #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2020
Merged

Fix select for pyarrow < 1.0.0 #585

merged 2 commits into from
Sep 8, 2020

Conversation

@lhoestq
Copy link
Member

@lhoestq lhoestq commented Sep 7, 2020

Fix #583

@lhoestq lhoestq requested a review from thomwolf September 7, 2020 15:02
@lhoestq lhoestq changed the title Fix select old pa Fix select for pyarrow < 1.0.0 Sep 7, 2020
thomwolf
thomwolf approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, good catch!

@lhoestq lhoestq merged commit 5b5c278 into master Sep 8, 2020
@lhoestq lhoestq deleted the fix-select-old-pa branch September 8, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomwolf thomwolf thomwolf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ArrowIndexError on Dataset.select

3 participants

@lhoestq @thomwolf