Skip to content

Conversation

@gaguilar
Copy link
Contributor

@gaguilar gaguilar commented Sep 1, 2020

Hi,

I have added the updated dataset_infos.json file for the LinCE benchmark. This update is to fix the mismatched checksum bug #539 for one of the datasets in the LinCE benchmark. To update the file, I run this command from the nlp root directory:

python nlp-cli test ./datasets/lince --save_infos --all_configs

NOTE: I needed to change this line from: from .utils.logging import get_logger to from nlp.utils.logging import get_logger, otherwise the script was not able to import get_logger. However, I did not include that in this PR since that could have been just my environment (and another PR could be fixing this already if it is actually an issue).

@thomwolf
Copy link
Member

thomwolf commented Sep 1, 2020

Thanks a lot for that!
The line you are mentioning is a bug indeed, do you mind fixing it at the same time?

@gaguilar
Copy link
Contributor Author

gaguilar commented Sep 1, 2020

No worries!

I pushed right away the fix, but then I realized that the master branch already had it, so I ended up merging the master branch with lince locally and then overwriting the previous commit in origin/lince. Hopefully, this is not too messy :)

@lhoestq lhoestq mentioned this pull request Sep 2, 2020
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the checksum :)

@thomwolf thomwolf merged commit 6fe854d into huggingface:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants