Skip to content

[Distributed] Making loading distributed datasets a bit safer #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

[Distributed] Making loading distributed datasets a bit safer #547

merged 1 commit into from
Aug 31, 2020

Conversation

@thomwolf
Copy link
Member

@thomwolf thomwolf commented Aug 31, 2020 •
edited
Loading

Add some file-locks during dataset loading

lhoestq
lhoestq approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filelocks everywhere :o

Thanks for fixing the test !

@thomwolf thomwolf merged commit ddf7a40 into master Aug 31, 2020
@thomwolf thomwolf deleted the distrib-loading branch August 31, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomwolf @lhoestq