Skip to content

Conversation

@jxmorris12
Copy link
Contributor

No description provided.

@lhoestq
Copy link
Member

lhoestq commented Aug 11, 2020

Thanks for adding this mirror link :)

Could you run the following command to update the json file dataset_infos.json used to verify the integrity of the downloaded file ?

nlp-cli test ./datasets/rotten_tomatoes --save_infos --ignore_verifications

@jxmorris12
Copy link
Contributor Author

done! @lhoestq

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@lhoestq
Copy link
Member

lhoestq commented Aug 12, 2020

the build_doc CI fail comes from master and has been fixed on master

Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do you want to rebase before merge to fix the CI error @jxmorris12?

@jxmorris12
Copy link
Contributor Author

done @thomwolf @lhoestq

@lhoestq lhoestq merged commit c1c6895 into huggingface:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants