Make battle pickle-able
#758
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 83.38% 84.86% +1.48%
==========================================
Files 39 44 +5
Lines 3918 5200 +1282
==========================================
+ Hits 3267 4413 +1146
- Misses 651 787 +136 🚀 New features to boost your workflow:
|
cameronangliss
changed the title
pickle-able
cameronangliss
force-pushed
the
dont-tie-gendata-onto-objects-its-huge
branch
from
76ac897 to
076db9e
Compare
cameronangliss
force-pushed
the
dont-tie-gendata-onto-objects-its-huge
branch
3 times, most recently
from
076db9e to
11c208f
Compare
cameronangliss
force-pushed
the
dont-tie-gendata-onto-objects-its-huge
branch
from
11c208f to
69cd1b9
Compare
hsahovic
requested changes
Jul 28, 2025
…er could make that happen themselves if they wish
…-tie-gendata-onto-objects-its-huge
cameronangliss
force-pushed
the
dont-tie-gendata-onto-objects-its-huge
branch
from
93a5a48 to
7314edc
Compare
…-tie-gendata-onto-objects-its-huge
cameronangliss
force-pushed
the
dont-tie-gendata-onto-objects-its-huge
branch
from
b68b72f to
b4bc1c3
Compare
cameronangliss
force-pushed
the
dont-tie-gendata-onto-objects-its-huge
branch
from
b4bc1c3 to
24e2d1a
Compare
…-tie-gendata-onto-objects-its-huge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's nice to be able to serialize/deserialize objects so you can store them in files and save your current situation. Now you can do that with
BattleandDoubleBattleobjects!_datafield containingGenData, and instead just callGenData.from_genwhenever they need the pokedex or something. This does not lose any performance and we were already doing this in some places, but allows these objects to be pickled now that they aren't carrying a pointer to the giantGenDataobject.EmptyMoveobject and its associated tests after realizing we never use that anywhere anymore.BattleandDoubleBattleobjects are now able to do round trip serialize/deserialize withpickle.Observation/ObservedPokemonobjects, not necessary now that battle objects are pickle-able, giving us a noticeable speed-up when playing battles.