Make open team sheets data populate the battle object #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsahovic
force-pushed
the
master
branch
2 times, most recently
from
7d8bd5b to
524b047
Compare
cameronangliss
force-pushed
the
open-sheets-fill-battle-obj
branch
from
9c3ae09 to
0572dff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 83.38% 83.63% +0.24%
==========================================
Files 39 44 +5
Lines 3918 5193 +1275
==========================================
+ Hits 3267 4343 +1076
- Misses 651 850 +199 🚀 New features to boost your workflow:
|
cameronangliss
added a commit
to cameronangliss/poke-env
that referenced
this pull request
Jan 3, 2025
…-sheets-fill-battle-obj
…-sheets-fill-battle-obj
cameronangliss
force-pushed
the
open-sheets-fill-battle-obj
branch
from
e726fe5 to
eab7037
Compare
cameronangliss
force-pushed
the
open-sheets-fill-battle-obj
branch
from
575378a to
4058e61
Compare
…-sheets-fill-battle-obj
cameronangliss
force-pushed
the
open-sheets-fill-battle-obj
branch
3 times, most recently
from
7aa5909 to
36cf7ec
Compare
cameronangliss
force-pushed
the
open-sheets-fill-battle-obj
branch
from
0c85577 to
be8ca19
Compare
cameronangliss
force-pushed
the
open-sheets-fill-battle-obj
branch
from
c02a163 to
1ad21a2
Compare
cameronangliss
force-pushed
the
open-sheets-fill-battle-obj
branch
from
1ad21a2 to
05d1b78
Compare
cameronangliss
force-pushed
the
open-sheets-fill-battle-obj
branch
from
7545534 to
1693b62
Compare
…-sheets-fill-battle-obj
hsahovic
approved these changes
Jun 22, 2025
hsahovic
pushed a commit
that referenced
this pull request
Jun 29, 2025
* add nicknames to one of the fixtures * fix test * fix test * fix * fix * try this * fix * give a request example * fix * try this * include species check * ah yes I forgot nicknames aren't revealed in the showdown text (idek) * try this * add request to try fix * break it into a different test * fix * recording nickname in pokemon object * shouldn't need this * improve test * fix test * make test better * fix test * improve test * improve test * improving test * fix test * format * fix test * fix test * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #609