Open Team Sheets #533
Merged
Open Team Sheets #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plemented open team sheet functionality
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
==========================================
- Coverage 83.38% 83.24% -0.15%
==========================================
Files 39 40 +1
Lines 3918 3998 +80
==========================================
+ Hits 3267 3328 +61
- Misses 651 670 +19 |
hsahovic
requested changes
Apr 14, 2024
src/poke_env/player/player.py
Outdated
| battle_format: str = "gen9randombattle", | ||
| log_level: Optional[int] = None, | ||
| max_concurrent_battles: int = 1, | ||
| open_team_sheet: bool = False, |
There was a problem hiding this comment.
Can you rename this parameter to accept_open_team_sheet?
src/poke_env/player/player.py
Outdated
| elif split_message[1] == "bigerror": | ||
| self.logger.warning("Received 'bigerror' message: %s", split_message) | ||
| elif split_message[1] == "uhtml": | ||
| if split_message[2] == "otsrequest": |
There was a problem hiding this comment.
uhtml messages are currently handled in battle.parse_message - can you combine the two conditions (eg. elif split_message[1] == "uhtml" and split_message[2] == "otsrequest") so that other messages are still parsed by it?
|
|
||
|
|
||
| def test_open_team_sheet(): | ||
| assert SimplePlayer(open_team_sheet=True).open_team_sheet |
There was a problem hiding this comment.
i would add a negative and a default test as well
hsahovic
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #530 added implementation to accept/reject open team sheets for formats that request it. By default, we reject open team sheets to save the privacy of the bots.
Changes:
Also, learned my lesson! It passes:
Hopefully this one is more straightforward!