Skip to content

Conversation

@Naapperas
Copy link

This PR adds a new screen for the user to see the currently playing track's lyrics and optionally save them to their system.
Closes #1076.

This behavior should be configurable by the user, i.e.:

  • the location for saving lyrics should be configurable (WIP);
  • the users preferred fetcher(s) should be configurable. For instance, they may want to only use MusixMatch or they may want to have several options available, with the next fetcher being used in case the previous is unavailable/invalid (WIP).

Missing features:

  • Lyric fetching (need to think about how to correctly abstract the fetching mechanism to use several implementations)
  • Lyrics page update (no access to music change event, at least none I could find, need to "manually" update, aka re-enter the view)
  • Asynchronous lyrics fetching (I looked into Cursive Async View but could not get it to work, still need to investigate further)

Still a Work In Progress but any comments/reviews/help are appreciated.

@Naapperas
Copy link
Author

Progress is slow due to college work but this is not forgotten

@hrkfdn
Copy link
Owner

hrkfdn commented Apr 14, 2023

@Naapperas No worries, good luck with college :)

@Naapperas
Copy link
Author

I was trying to fix some organizational aspects of the PR and i guess Github closed it for me (?!?!)

@Naapperas Naapperas mentioned this pull request Apr 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add time-synced lyrics tab

2 participants