Proposal: add a simple contribution guide #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 79.59% // Head: 79.59% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 79.59% 79.59%
=======================================
Files 5 5
Lines 838 838
=======================================
Hits 667 667
Misses 129 129
Partials 42 42 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
houqp
approved these changes
Jan 19, 2023
houqp
reviewed
Jan 19, 2023
| `go get` or `go install` puts sqlvet in `$GOPATH` or `$HOME/go`. You're able to fork and the repo into another directory to make changes. `go test ./...` works pretty well for testing changes. | ||
|
|
||
| ## Development Workflow Requirements | ||
| The `const version` needs to be updated with changes before new releases are tagged and published. |
There was a problem hiding this comment.
for future improvements, we could also dynamically inject the version value at build time during release CI runs using the tag value so we don't need to maintain versions in multiple places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You've made a useful and now popular (rightfully so) linter, and I think this code deserves community support. We got a ticket (#22) about the version being wrong which I would have fixed during my work if I had taken note.
This is a simple contribution guide for your consideration.