Allow setting turbo-suppress-warning on body element #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning previously made it look like placing the data-turbo-suppress-warning attribute on the body element would suppress it, but in fact, only the script tag was being checked for this attribute. Now, data-turbo-suppress-warning on the body element will also suppress the warning. The script tag check is kept unchanged to avoid breaking existing code. The warning message has been updated to mention both possibilities (script tag and body tag) as valid places for data-turbo-suppress-warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning previously made it look like placing the data-turbo-suppress-warning attribute on the body element would suppress it, but in fact, only the script tag was being checked for this attribute.
Now, data-turbo-suppress-warning on the body element will also suppress the warning.
The script tag check is kept unchanged to avoid breaking existing code.
The warning message has been updated to mention both possibilities (script tag and body tag) as valid places for
data-turbo-suppress-warning.
Before:
Notice the data-turbo-suppress-warning attribute already present on the body tag, while the message suggests adding it
After:
The body tag no longer has the data-turbo-suppress-warning attribute, because the warning would no longer appear if it had it