Skip to content

Allow ValueTypeObject to be provided as a Partial #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2023
Merged

Allow ValueTypeObject to be provided as a Partial #650

merged 1 commit into from
Feb 2, 2023

Conversation

marcoroth
Copy link
Member

This pull request allows ValueTypeObject to be provided as a Partial. Additionally, it adds some test cases for the functions used in value_properties.ts.

This is now valid:

static values = {
  id: { type: String }
}

Fixes #487

@marcoroth marcoroth mentioned this pull request Feb 2, 2023
Closed
@marcoroth marcoroth force-pushed the value-type-object-partial branch from 226f985 to d4c9e7b Compare February 2, 2023 00:33
@dhh dhh merged commit 8217e9b into hotwired:main Feb 2, 2023
@marcoroth marcoroth deleted the value-type-object-partial branch February 2, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "default" optional in expanded form
2 participants
@marcoroth @dhh