fix: Skip content-length assignment when transfer-encoding is chunked. #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yusukebe |
|
Thank you for the quick fix. Looks good! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #270
In
responseViaCache, we avoided searching forTransfer-Encodingbecause it was computationally expensive when the header object passed was aRecord<string, string>. However, in this case, we assume that the body is not chunked if it is astringorBlob, so we would like to process it based on that assumption. (This has actually been the behavior so far.)In
responseViaResponseObject, we had also avoided referencingTransfer-Encodingto align withresponseViaCache, but since there are actual issues like #270, I would like to avoid settingContent-LengthifTransfer-Encodingis chunked.