-
Notifications
You must be signed in to change notification settings - Fork 66
perf: keep using the lightweight Response object when retrieving headers
, status
, and ok
, and then drop the getInternalBody
function.
#242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le, to improve performance
74161ae
to
f657cae
Compare
yusukebe
reviewed
May 19, 2025
yusukebe
approved these changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@usualoma I think this is good! Can I merge now? |
@yusukebe Thank you. Please!
|
Okay! Let's go. |
Sorry to bother you all, but I noticed that after this pr merge, the streaming return no longer seems to work, in a similar situation to #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts usualoma#3, excludes #241, and completely removes the functionality of
getInternalBody
.support more response body types for caching
In d72de8d, I made the optimization pattern previously covered by
getInternalBody
return from a faster cache.benchmark
script
main branch
usualoma:feat-more-use-respose-cache-2 branch