Skip to content

Conversation

Soviut
Copy link
Contributor

@Soviut Soviut commented Jul 15, 2025

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Closes #4281

I will write docs if this idea gets accepted.

@Soviut Soviut changed the title Generate-cookie-helper feat: generateCookie and generateSignedCookie helpers Jul 15, 2025
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.62%. Comparing base (89f4c96) to head (3c5c080).
⚠️ Report is 30 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4285      +/-   ##
==========================================
+ Coverage   91.61%   91.62%   +0.01%     
==========================================
  Files         170      170              
  Lines       10875    10888      +13     
  Branches     3099     3115      +16     
==========================================
+ Hits         9963     9976      +13     
  Misses        911      911              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe changed the title feat: generateCookie and generateSignedCookie helpers feat(cookie): generateCookie and generateSignedCookie helpers Jul 22, 2025
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Hi @Soviut

Thank you for the PR! I think this feature is helpful. The implementation is also good. This is a new feature, so basically we can include this in the next minor release. Please wait for merging into the branch for the minor bump.

@yusukebe yusukebe changed the base branch from main to next August 7, 2025 11:14
@yusukebe yusukebe merged commit fbd2ff1 into honojs:next Aug 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a generateSignedCookie function to the hono/cookie helper for testing
2 participants