-
-
Notifications
You must be signed in to change notification settings - Fork 790
feat(jwk): Add custom headerName
to JWK middleware
#4279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4279 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 170 170
Lines 10836 10837 +1
Branches 3225 3159 -66
=======================================
+ Hits 9928 9929 +1
Misses 907 907
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you for the PR. Can you add proper tests? |
Will add tests and open a proper PR, thanks for the feedback @yusukebe |
headerName
to JWK middleware
Okay, all should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! Looks good to me. It's a new feature, so basically it will be introduced in the next minor version, but it's a slight change. So, it may be included in the patch release. I'll decide it later. |
RFC: Enable JWK middleware to read from custom header, similar to the cookie.
This will provider more flexibility for different use cases like Cloudflare Zero Trust Access that sends the assertion token on
Cf-Access-Jwt-Assertion
header.The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code