Skip to content

Conversation

subzero10
Copy link
Member

Closes #9.

@subzero10 subzero10 requested a review from joshuap July 3, 2025 06:26
@subzero10 subzero10 self-assigned this Jul 3, 2025
@subzero10 subzero10 force-pushed the docs-set-test-notification branch from 8ab3d6b to aaab8cf Compare July 3, 2025 06:33
@subzero10 subzero10 requested a review from Copilot July 4, 2025 06:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the examples and documentation by switching to asynchronous test notifications and adding a “Send a test notification” guide.

  • Switched the console sample to use NotifyAsync for test notifications.
  • Removed outdated environment-reporting notes and introduced a dedicated test-notification section.
  • Updated variable names in README snippets for consistency.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
examples/Honeybadger.Console/Program.cs Changed client.Notify to await client.NotifyAsync(...) in the console example
README.md Removed old environment notes, added “Send a test notification” section, and refined code snippets
Comments suppressed due to low confidence (3)

README.md:140

  • [nitpick] This note repeats guidance given earlier. Consider centralizing it in one place or linking to the original section to avoid duplication.
**Note**: Honeybadger, by default, will not report errors in development environments.

README.md:194

  • [nitpick] The comment // fire and forget can be misleading since Notify is a synchronous call. Clarify whether this truly runs asynchronously or update the comment to reflect its blocking nature.
// fire and forget

examples/Honeybadger.Console/Program.cs:18

  • This await call requires an async entry point. Ensure Program.cs uses static async Task Main(string[] args) or wrap the call in .GetAwaiter().GetResult() to compile correctly.
await client.NotifyAsync("Hello from .Net! Improved error handling with Honeybadger.");

@subzero10 subzero10 merged commit 4d18216 into main Jul 4, 2025
1 check passed
@subzero10 subzero10 deleted the docs-set-test-notification branch July 4, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "send a test error" step to setup instructions
1 participant