Finish Identify Characteristic #77
Conversation
Sets Characteristic.identify to true and uses the Roomba find command to locate the device. Requires dorita980 3.1.10
There was a problem hiding this comment.
It's a bit weird to have all of these white space changes in this PR. They muddy the PR with unrelated changes. I think the changes are good! They just don't belong here. If you'd like to split them into a separate PR "tidy white space" or similar, that would be great.
src/accessory.ts
Outdated
| await roomba.find(); | ||
| callback(); | ||
| } catch (error) { | ||
| this.log("Unable to Locate"); |
There was a problem hiding this comment.
Should the callback be called with an error at this point? Check the signature of the callback; usually they support receiving an error object.
There was a problem hiding this comment.
White space moved to separate PR.
Can you check this? I updated with the new main branch and noticed several key changes you've made. Hopefully this update falls in line with those, but let me know if you see any issues or concerns.
Implements Roomba Find function using HK Identify characteristic.
|
@rcoletti116 sorry this took me so long; the whitespace issues weren't resolved in this PR... you can see on the Files Changed tab. Also the changes weren't type safe, it appears; the |
2 participants
Changes:
Apple's Home app doesn't regularly expose the identify feature, but most 3rd party apps (Eve, Controller, Home+) do. Triggering 'Identify' will send a find command to the roomba, which will then beep various tones and pulse its status lights. This is ideal for finding when it has been stopped or stuck under a bed or similar.