Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 21, 2025

Working on resolving issue #520 where some error messages are logged without timestamp and plugin name.

Analysis & Plan

  • Explore repository structure and understand logging system
  • Identify that rainbird library emits log events correctly
  • Confirm platform listens to these events in platform.ts lines 178-192
  • Verify LogLevel enum values match expected strings
  • Identify root cause of bypass logging
  • Test current logging behavior
  • Implement fix for missing timestamp/plugin name
  • Verify fix works correctly
  • Clean up and document changes

Current Understanding

The issue appears to be that some error messages bypass the homebridge logging system and are logged directly to console without timestamp and plugin name. The platform correctly listens for rainbird library log events and routes them through proper homebridge logging methods, but there may be an edge case or timing issue causing some logs to bypass this system.

The error messages mentioned in the issue:

  • "RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]"
  • "Failed Request: [18] [ControllerDateGetRequest]"
  • "Will retry in 60 seconds"

These should be caught by the platform's event listener and logged with proper timestamps and plugin names.

Fixes #520.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Contributor Author

Copilot AI commented Aug 21, 2025

@donavanbecker 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI and others added 2 commits August 21, 2025 13:50
Co-authored-by: donavanbecker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Some errors are logged without timestamp and plugin name
2 participants