Skip to content

Conversation

@edenhaus
Copy link
Member

Proposed Changes

Add a supported version range instead of a single version

@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.04%. Comparing base (140d2cb) to head (6f045f7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   97.14%   97.04%   -0.10%     
==========================================
  Files           7        7              
  Lines         245      271      +26     
  Branches       35       43       +8     
==========================================
+ Hits          238      263      +25     
  Misses          5        5              
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the name of the upper version bound is misleading. OK to merge though.

@edenhaus edenhaus added enhancement Enhancement of the code, not introducing new features. refactor Improvement of existing code, not introducing new features. and removed enhancement Enhancement of the code, not introducing new features. labels Oct 28, 2024
@edenhaus edenhaus merged commit eaf3d1e into main Oct 28, 2024
7 of 9 checks passed
@edenhaus edenhaus deleted the supported-version-range branch October 28, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactor Improvement of existing code, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants