Skip to content

Conversation

@edenhaus
Copy link
Member

@edenhaus edenhaus added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Oct 28, 2024
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (eaf3d1e) to head (c52d960).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   97.04%   97.77%   +0.72%     
==========================================
  Files           7        7              
  Lines         271      270       -1     
  Branches       43       43              
==========================================
+ Hits          263      264       +1     
+ Misses          5        4       -1     
+ Partials        3        2       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._client.receive() should only ever raise asyncio.CancelledError or asyncio.TimeoutError (only if a timeout is specified) so the try/except is likely unneeded but it probably isn't hurting anything unless this code is performance sensitive... and even then with Python 3.11+ try is near zero relative cost

@edenhaus edenhaus merged commit 73fa4fa into main Oct 29, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants