-
Notifications
You must be signed in to change notification settings - Fork 3
Fix ws receive task #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 97.04% 97.77% +0.72%
==========================================
Files 7 7
Lines 271 270 -1
Branches 43 43
==========================================
+ Hits 263 264 +1
+ Misses 5 4 -1
+ Partials 3 2 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._client.receive() should only ever raise asyncio.CancelledError or asyncio.TimeoutError (only if a timeout is specified) so the try/except is likely unneeded but it probably isn't hurting anything unless this code is performance sensitive... and even then with Python 3.11+ try is near zero relative cost
Proposed Changes